feat: New sync flags for replace and force #653
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 54.26% 54.41% +0.14%
==========================================
Files 64 64
Lines 6164 6337 +173
==========================================
+ Hits 3345 3448 +103
- Misses 2549 2611 +62
- Partials 270 278 +8 ☔ View full report in Codecov by Sentry. |
Gitops-engine part of argoproj/argo-cd#21427 Add new way of specifying options and include options always and never. Also, include a way to specify options per group/kind. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada
force-pushed
the
20730-handle-different-sync-flags
branch
from
855b7b5 to
548f0bb
Compare
|
There was a problem hiding this comment.
I am not sure if this is the appropriate solution to the problem. I am mainly concerned with confusion that this would bring to users when there is no clear indication of how Argo CD is applying resources. As discussed in the contrib meeting, we need to better understand the edge cases that this would bring (e.g. how to manage conflicts with UI configuration during syncs)
The alternative seems worse due to autosync just not working when there's a mix of resources that need to be synced with replace always and replace never. With my approach I don't see any nasty edge cases - we have one sync and "Replace (if allowed)" checkbox. Just resources which should be replaced are replaced and resources which aren't allowed to be replaced are synced normally. Do you have any specific edge cases in mind? |
Gitops-engine part of argoproj/argo-cd#21427
Add new way of specifying options and include options always and never. Also, include a way to specify options per group/kind.